-
-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Difficulties adding plugin with responsive styles #96
Comments
Thanks for the excellent report on this issue frank, I'll take a look into it and get back to you. |
Hey Frank, just a quick update - I've located the issue and I'm working on a patch. |
The fix for this is now in v1.5.0 🎉 I've made you a fluid-container demo in CRA → |
Confirmed this fix works locally on my project. Thanks a lot! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I'm trying to create and use
fluidContainer
plugin with the following code:When I use this class using
tw
, the default styles are applied, but for the 768 and 1440 breakpoints I don't see the rules being applied. I compiled them successfully using postcss into a css file, and withclassName="fluid-container"
everything works, although obviously I don't want to useclassName
. This gives me an indication that the plugin is written correctly.The plugin is loosely based on
container
, so I tried to compare them while debugging.I did
<div tw="container fluid-container">
and the output is:As you can see, the responsive styles for
container
are outputted, but not the responsive styles forfluid-container
.When I log the generated config for both plugins, they look very similar.
Since
addComponents
is supported by twin.macro, I expect everything to work with twin.macro.I wonder if you could track down this issue and hopefully provide a fix/solution.
I use
[email protected]
,[email protected]
and[email protected]
.The text was updated successfully, but these errors were encountered: