-
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Any plans for the next release? #19
Comments
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
As I'm experiencing the same issue as @fauno (and originally raised by @qwtel in #16) I would like to support the request for a release with the fix in #17. I'm trying to improve the scalability of Just the Docs for sites with large navigation panels. Locally building the theme docs together with regression tests currently takes more than 600 seconds using the current release (0.2.0) of this gem, whereas it takes just 25 seconds using the current master! (Jekyll 4.1.1 on macOS Catalina, MacBook Air (Retina, 13-inch, 2018), 1.6 GHz Dual-Core Intel Core i5, Memory 16 GB 2133 MHz LPDDR3) This is the first time I've tried using this gem, and I know very little about Ruby and Jekyl, but I think the cause of the issue with 0.2.0 is that I'm passing arrays of pages as parameters to recursive inclusions of the file that creates the navigation links, and hashing the parameters is taking a long time (perhaps aggravated by GC). I could work around the issue (replacing the arrays of pages by arrays of their required fields) but #17 appears to address the root cause of the current inefficiency. |
Those are some impressive gains! Glad it works so well 👍 |
@qwtel It turned out that the magnitude of the gains I reported was partly due to a page-dependent parameter (the navigation path to the page) which inhibited reuse of the cached navigation links. Nevertheless, getting the build time down was very helpful for debugging. After further analysis and optimisation, I've managed to get good cache reuse with larger navigation hierarchies. @benbalter Many thanks for releasing v0.2.1 so quickly in response to my support for @fauno's request – much appreciated! |
I was debugging why the site I'm working on wasn't caching includes until I noticed there were some changes on master, so I tried it and without changing the templates the build time went from 100 to 20 seconds and includes were being cached :)
The text was updated successfully, but these errors were encountered: