Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AAPS data always exposed to local web server #13

Open
Trenar opened this issue Feb 10, 2022 · 2 comments
Open

AAPS data always exposed to local web server #13

Trenar opened this issue Feb 10, 2022 · 2 comments

Comments

@Trenar
Copy link

Trenar commented Feb 10, 2022

Subject of the issue

This version of xDrip+ always emits an "aaps" string in e.g. http://127.0.0.1:17580/sgv.json?count=24, like

"aaps":"🔺1.658U ⏱1092h2m 📅5d11h","aaps-ts":1644483391375

This is unexpected, since no AAPS connection is made (on my device). Furthermore, I suspect that the special characters / emojis are compatible with AAPS, but this is just a wild guess.

Your environment

xDripCareLinkFollower / master branch / beta 0.1.2

Expected behavior

If no AAPS connection is there, these strings shouldn't be exposed
It's related to the file dexdrip/webservices/WebServiceSgv.java, lines 148-153:

// emit the external status line once if present
  if (external_status_line.length() > 0) {
  item.put("aaps", external_status_line);
  item.put("aaps-ts", getLastStatusLineTime());
  external_status_line = "";
} 

Steps to reproduce the behavior:

Set up xDripCareLinkFollower with your minimed connect follower account, and on your phone type http://127.0.0.1:17580/sgv.json?count=24. You'll see the lines quoted above.

Best,
Trenar

@benceszasz
Copy link
Owner

Most of the CareLink Follower functions were merged into the offical xdrip on 02.11.2022. Since extra status line and external status functions of CareLink Follower were not merged, you can use the official xdrip without this issue.

@Trenar
Copy link
Author

Trenar commented Dec 8, 2022

Hi,
thx for the reply. Meanwhile, I moved towards using Nightscout with the mmed plugin, which also serves my purposes. Anyway, thanks for your hard work on this :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants