Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

guess_protocol() falls back to Halfblocks on Windows Terminal (Preview) #37

Open
matthias-buttgereit opened this issue Aug 29, 2024 · 2 comments

Comments

@matthias-buttgereit
Copy link

Windows Terminal (Preview) supports Sixel as of 1.22 (https://github.com/microsoft/terminal/releases).

When running code inside WSL it does actually display images using Sixel but outside of WSL it falls back to Halfblocks.

Windows Terminal (Preview) without WSL Windows Terminal (Preview) with WSL
Screenshot 2024-08-29 191116 Screenshot 2024-08-29 191146

My guess is that the guess_protocol() function is not testing for Sixel support under Windows. Not sure if there is a way to do it yet but would be great if it could be added.

@j4james
Copy link

j4james commented Sep 3, 2024

FYI, there is a bug in the latest Windows Terminal preview that affects VT reports in applications that don't enable VT input mode (see microsoft/terminal#17813). It's possible that might be why it's not working outside WSL. VT input mode is set automatically in WSL, but that isn't the case for regular Windows console applications, unless they set the mode themselves, and I don't think the crossterm library does that.

@matthias-buttgereit
Copy link
Author

Seems like Sixel is working in Windows Terminal (Preview) even without WSL when you manually cycle through the protocols (like in the demo example).

Screenshot 2024-09-10 175542

Just showing some weird behaviour when resizing (not fully clearing the area) but that might be a problem on the Windows Terminal part.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants