Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to select unpin behavior #25

Closed
benji300 opened this issue Jan 11, 2021 · 5 comments
Closed

Add option to select unpin behavior #25

benji300 opened this issue Jan 11, 2021 · 5 comments
Labels
enhancement New feature or request
Milestone

Comments

@benji300
Copy link
Owner

Add user option to specify the behavior when the selected note is unpinned from the tabs.
Selectable values:

  • KEEP_SELECTED - current behavior, selected note is unpinned and replaces temporary tab
  • SELECT_LAST_ACTIVE - selected note is completely removed from tabs and the last edited note is selected
  • SELECT_ADJACENT - same behavior for current selected note as SELECT_LAST_ACTIVE, but new selected note will be either the left or right adjacent note. Depending on which exists. Where the left one is preferred.
@benji300 benji300 added the enhancement New feature or request label Jan 11, 2021
@benji300 benji300 added this to the v1.2.0 milestone Jan 11, 2021
@benji300
Copy link
Owner Author

Waiting for this discussion.

@benji300 benji300 modified the milestones: v1.2.0, v1.3.0 Feb 1, 2021
@yiwiz-sai
Copy link

can we have a option to do like this, when I click a note not in the tabs, it can create a new tab and show it (like chrome)...

currently it always replaces the last unpinned one.

@benji300
Copy link
Owner Author

benji300 commented Feb 4, 2021

@pianoboysai: I'm not quite sure if I understood you correctly. Do you know the command Tabs: Pin note? This is used to pin a note directly to the tabs. It can be called from the context menu for any note (must not be the selected one). However, it does not automatically select (open) the note.
Is this what you mean? When selecting a note, pin it directly and not open it as a temporary tab?

@yiwiz-sai
Copy link

@pianoboysai: I'm not quite sure if I understood you correctly. Do you know the command Tabs: Pin note? This is used to pin a note directly to the tabs. It can be called from the context menu for any note (must not be the selected one). However, it does not automatically select (open) the note.
Is this what you mean? When selecting a note, pin it directly and not open it as a temporary tab?

Hi benji300, what I mean is, when I select a note in sidebar, directly open it in a new tab (just like chrome), do not replace content in current pined tab.

@benji300
Copy link
Owner Author

benji300 commented Feb 5, 2021

I've created a new ticket #35 for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants