Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check regionNames string in countries i18n files #776

Open
benkeen opened this issue Nov 17, 2022 Discussed in #773 · 1 comment
Open

Check regionNames string in countries i18n files #776

benkeen opened this issue Nov 17, 2022 Discussed in #773 · 1 comment

Comments

@benkeen
Copy link
Owner

benkeen commented Nov 17, 2022

Discussed in #773

As discussed above. Possibly we can just ditch this value now.

@andrefortin
Copy link

It is not being referenced except for in the type [CountryDataType] found in the file "/client/types/countries.d.ts"

export type CountryDataType = {
countrySlug: string;
countryName: string;
regionNames: string;
continent: Continent;
regions: Region[];
extendedData: ExtendedData;
};

We are actually using the value incorrectly as it represents "What does this country call its regional subdivisions?".

For the USA is should simply be: "States", for Canada: "Provinces".

Now that the user interface uses the generic term "Region" and it gets translated in the UI this value is not required.
However I'd be for keeping it and simply updating it to the actual correct usage in the files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants