Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON validation should fail when multiple rows have same title #796

Open
benkeen opened this issue Dec 14, 2022 · 1 comment
Open

JSON validation should fail when multiple rows have same title #796

benkeen opened this issue Dec 14, 2022 · 1 comment

Comments

@benkeen
Copy link
Owner

benkeen commented Dec 14, 2022

Minor, but still invalid & should be caught. Note that this doesn't apply to all Export Types. With XML, for example, it's perfectly valid.

@benkeen
Copy link
Owner Author

benkeen commented Feb 25, 2023

This requires an enhancement of the core script.

Right now the Export Types do the job of validating the title field via the validateTitleField callback (ETValidateTitleField interface). In order to accommodate this, that method will need to be updated to pass in all row titles, plus the index of the current row. That would enable it to show an appropriate error + notify the user about which rows were in conflict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant