Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom resolvers: must load eslint-import-resolver-{x} form _first_ #373

Closed
benmosher opened this issue Jun 9, 2016 · 5 comments
Closed
Labels
Milestone

Comments

@benmosher
Copy link
Member

Allowing explicit packages to have precedence means that webpack is being loaded to resolve instead of eslint-import-resolver-webpack.

Blocks v1.9.0 release. (#372)

@benmosher benmosher added the bug label Jun 9, 2016
@benmosher benmosher modified the milestones: next, v1.9.x Jun 9, 2016
benmosher added a commit that referenced this issue Jun 9, 2016
@avaragado
Copy link

@benmosher I've just spent an hour working out why my config wasn't working, and it's because of this issue. I have eslint-plugin-import 1.9.0, with eslint-import-resolver-webpack 0.3.1.

Any chance of releasing this fix soon?

@benmosher
Copy link
Member Author

@avaragado just published 1.9.1 with just this patch.

How did you end up with 1.9.0 installed? I hid it behind the next tag on npm so that it wouldn't be public-facing, ideally.

@avaragado
Copy link

@benmosher Looking through my command-line history, it seems it was presented under the 'Wanted' column of npm outdated. The 'Latest' column showed 1.8.1. I guess I jumped the gun.

@benmosher
Copy link
Member Author

I was worried that might happen. 😞 I think 1.9.x is semver-valid if your package.json has something like ^1.8.1. So that's on me, I didn't realize npm would install versions past the latest tag.

@avaragado
Copy link

Yeah, that's the situation I was in. npm update ignores those tags, it seems, and follows the semver specified in package.json.

I've updated to 1.9.1 and it works, so thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

2 participants