Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make aggregating modules valid in group-exports #1472

Merged
merged 1 commit into from
Sep 11, 2019
Merged

Make aggregating modules valid in group-exports #1472

merged 1 commit into from
Sep 11, 2019

Conversation

atikenny
Copy link

@atikenny atikenny commented Sep 7, 2019

Fixes #1471

@coveralls
Copy link

coveralls commented Sep 7, 2019 •
edited
Loading

Coverage Status

Coverage increased (+0.007%) to 97.908% when pulling 2e047e6 on atikenny:master into 726dda5 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 97.901% when pulling 96d0246 on atikenny:master into 726dda5 on benmosher:master.

@atikenny atikenny requested a review from ljharb September 8, 2019 16:11
ljharb
ljharb reviewed Sep 8, 2019
View reviewed changes
docs/rules/group-exports.md Outdated Show resolved Hide resolved
@atikenny atikenny requested a review from ljharb September 8, 2019 17:14
ljharb
ljharb reviewed Sep 8, 2019
View reviewed changes
src/rules/group-exports.js Outdated Show resolved Hide resolved
@atikenny atikenny requested a review from ljharb September 8, 2019 17:51
@ljharb ljharb merged commit 2e047e6 into import-js:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
semver-minor
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

group-exports aggregating modules should be valid
3 participants
@atikenny @coveralls @ljharb