Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[no-internal-modules] allow importing @-scoped modules #578

Merged
merged 1 commit into from
Sep 26, 2016
Merged

[no-internal-modules] allow importing @-scoped modules #578

merged 1 commit into from
Sep 26, 2016

Conversation

spalger
Copy link
Contributor

@spalger spalger commented Sep 23, 2016

Fixes #577 by counting the steps that do not start with @

Copy link
Collaborator

@jfmengels jfmengels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind adding an invalid case for import b from "@org/package/internal.js"?

@jfmengels
Copy link
Collaborator

Thanks a lot for the fix @spalger!

@jfmengels
Copy link
Collaborator

@benmosher I think there are failing tests for the exports rule on master. Do you know of anything changing recently?

@spalger
Copy link
Contributor Author

spalger commented Sep 24, 2016

@jfmengels updated

@jfmengels
Copy link
Collaborator

Awesome, LGTM :)

@benmosher For the errors, seems like a dependency (a parser?) now considers some of the invalid test cases from export as invalid syntax. So that's all good, we just need to update the expected error message / change the parser for those tests to keep supporting other parsers that allow the syntax.

Anyway, nothing for you to worry for this PR @spalger ;)

@jfmengels
Copy link
Collaborator

We just merged the v2 branch, this needs to be rebased :s

@spalger
Copy link
Contributor Author

spalger commented Sep 24, 2016

I'm tethering, so I'd rather not pull all the new deps, but I think that should do it

@coveralls
Copy link

coveralls commented Sep 24, 2016

Coverage Status

Coverage increased (+0.001%) to 97.816% when pulling b8663fd on spalger:fix/scoped-no-internal into e3c41ca on benmosher:master.

@jfmengels
Copy link
Collaborator

Still LGTM, thanks for your patience on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants