-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[no-internal-modules] allow importing @-scoped modules #578
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mind adding an invalid case for import b from "@org/package/internal.js"
?
Thanks a lot for the fix @spalger! |
@benmosher I think there are failing tests for the |
@jfmengels updated |
Awesome, LGTM :) @benmosher For the errors, seems like a dependency (a parser?) now considers some of the invalid test cases from Anyway, nothing for you to worry for this PR @spalger ;) |
We just merged the v2 branch, this needs to be rebased :s |
I'm tethering, so I'd rather not pull all the new deps, but I think that should do it |
Still LGTM, thanks for your patience on this! |
Fixes #577 by counting the steps that do not start with
@