Clean up traceback printing in arbitar #1201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 can you rebase the commits in 1 ? will merge it right after. |
Manually including the traceback in the log msg causes some issues when interacting with log formats, and in one case was causing the traceback to be printed twice.
bloodearnest
force-pushed
the
double_exc
branch
from
7c1ada6
to
0acfb55
Compare
|
Done, thanks |
benoitc
added a commit
that referenced
this pull request
Feb 9, 2016
Clean up traceback printing in arbitar
|
thanks! |
wking
added a commit
to wking/gunicorn
that referenced
this pull request
Nov 3, 2017
The argument is documented in [1], and we've been using it in some cases since 410bcfa (Fix statsd logging to work on Python 3, 2015-04-20, benoitc#1010). This commit goes through all of our log calls and makes sure we're using it consistently. For more examples of using exc_info instead of direct traceback calls, see 0acfb55 (Let logging module handle traceback printing, 2016-02-05, benoitc#1201). The traceback call I'm removing snuck in later with f4842a5 (Log exception occurring during worker exit, 2016-05-04, benoitc#1254). I'm removing the "Error processing SSL request" debug messages, because those will be handled by the subsequent handle_error call. We've had them, for reasons that I'm not clear on, since 1198cc2 (handle ssl connections, 2012-12-14). I've restored logging in the URI-less Worker.handle_error 500 case, since that was broken in 79011d0 (Include request URL in error message, 2015-07-08, benoitc#1071) but not restored in 1ccebab (prevent crash when reporting an error, 2016-03-22, benoitc#1231). [1]: https://docs.python.org/2/library/logging.html#logging.Logger.debug
wking
added a commit
to wking/gunicorn
that referenced
this pull request
Nov 3, 2017
The argument is documented in [1], and we've been using it in some cases since 410bcfa (Fix statsd logging to work on Python 3, 2015-04-20, benoitc#1010). This commit goes through all of our log calls and makes sure we're using it consistently. For more examples of using exc_info instead of direct traceback calls, see 0acfb55 (Let logging module handle traceback printing, 2016-02-05, benoitc#1201). The traceback call I'm removing snuck in later with f4842a5 (Log exception occurring during worker exit, 2016-05-04, benoitc#1254). I'm removing the "Error processing SSL request" debug messages, because those will be handled by the subsequent handle_error call. We've had them, for reasons that I'm not clear on, since 1198cc2 (handle ssl connections, 2012-12-14). I've restored logging in the URI-less Worker.handle_error 500 case, since that was broken in 79011d0 (Include request URL in error message, 2015-07-08, benoitc#1071) but not restored in 1ccebab (prevent crash when reporting an error, 2016-03-22, benoitc#1231). Tests for the lines I've touched may be more trouble than they're worth. I've worked up one for a broken worker_exit hook to show what they look like, but left the others untested for now. [1]: https://docs.python.org/2/library/logging.html#logging.Logger.debug
wking
added a commit
to wking/gunicorn
that referenced
this pull request
Nov 3, 2017
The argument is documented in [1], and we've been using it in some cases since 410bcfa (Fix statsd logging to work on Python 3, 2015-04-20, benoitc#1010). This commit goes through all of our log calls and makes sure we're using it consistently. For more examples of using exc_info instead of direct traceback calls, see 0acfb55 (Let logging module handle traceback printing, 2016-02-05, benoitc#1201). The traceback call I'm removing snuck in later with f4842a5 (Log exception occurring during worker exit, 2016-05-04, benoitc#1254). I'm removing the "Error processing SSL request" debug messages, because those will be handled by the subsequent handle_error call. We've had them, for reasons that I'm not clear on, since 1198cc2 (handle ssl connections, 2012-12-14). I've restored logging in the URI-less Worker.handle_error 500 case, since that was broken in 79011d0 (Include request URL in error message, 2015-07-08, benoitc#1071) but not restored in 1ccebab (prevent crash when reporting an error, 2016-03-22, benoitc#1231). Tests for the lines I've touched may be more trouble than they're worth. I've worked up one for a broken worker_exit hook to show what they look like, but left the others untested for now. [1]: https://docs.python.org/2/library/logging.html#logging.Logger.debug
mjjbell
pushed a commit
to mjjbell/gunicorn
that referenced
this pull request
Mar 16, 2018
Clean up traceback printing in arbitar
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, on some errors, tracebacks are manually included in the log message. This patch instead uses the stdlibs logging traceback printing. This allow better log customisation and control.
Additionally, because the call to logging.exception included the traceback in its log message, the traceback was printed twice the logs, as logging.exception always prints the traceback.
I've left the exceptions logged at debug/info as they are, but it seems to me they'd be better off as error level, since we sys.exit() after both anyway,