fix infinite recursion when destroying sockets #1219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By having a `getattr` implementation that proxies to the `sock` attribute, there is a risk of infinite recursion when the socket attribute is absent. After closing the socket and destroying it, the recursion can be prevented by setting the attribute to `None`.
tilgovi
force-pushed
the
fix/socket-destroy-recursion
branch
from
dca088d
to
e46dda7
Compare
|
+1 |
tilgovi
added a commit
that referenced
this pull request
Mar 13, 2016
fix infinite recursion when destroying sockets
mjjbell
pushed a commit
to mjjbell/gunicorn
that referenced
this pull request
Mar 16, 2018
…sion fix infinite recursion when destroying sockets
This was referenced Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By having a
getattrimplementation that proxies to thesockattribute, there is a risk of infinite recursion when the socket
attribute is absent. After closing the socket and destroying it,
the recursion can be prevented by setting the attribute to
None.