Spanish translation while on the dashboard displays hashes instead of the job status name

[ronb54]

Hello! 👋

I recently started using this gem for my project. While clicking around on the dashboard after initial setup, I toggled between translations and noticed hashes were being displayed on the job status names. A picture's worth a thousand words they say, so here's what I mean:

See it here on the demo app as well: https://goodjob-demo.herokuapp.com/good_job/jobs?locale=es&state=scheduled.

Looks like a simple change to handle hashes in the shared _filter partial. And the es locale seems to be the only one that has multiple translations.

    status:
      discarded:
        one: Descartada
        other: Descartadas
      queued:
        one: Encolada
        other: Encoladas
  .....

All the other locales are defined with a simple string (e.g. de):

    status:
      discarded: Ausrangiert
      queued: In der Warteschlange
      retried: Wiederholt

I could do a quick PR if this hasn't been PR'd already. Let me know.

I also don't have the context for why es has the nested config. Perhaps there's a future plan for using the alternate translation?

[bensheldon]

Thanks for catching this! That's weird because it's doing the correct thing in development:

The count is passed into the translation, which should determine the plural form:

good_job/app/views/good_job/shared/_filter.erb

Line 58 in 0c3541a

<%= t(name, scope: 'good_job.status', count: count) %>

So I guess I see two problems:

• I don't think the tabs should be pluralized (I think these are "past participles")
• Why isn't it working the same in production as development ?? 😕

I'd accept a PR if you wanted to remove the plural forms.

[bensheldon]

Why isn't it working the same in production as development ?? 😕

Oh! In development I was running an older version (v3.26.2). I can reproduce it on main. Now to figure out what happened!

[bensheldon]

Sorry to just keep posting through it... :D

I figured it out. Those counts became asynchronous in #1286

so count is always nil now in this line:

good_job/app/views/good_job/shared/_filter.erb

Line 58 in 0c3541a

<%= t(name, scope: 'good_job.status', count: count) %>

I'm in the code right now so I can fix it real quick right now. Thank you for reporting this!!