Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adapter to implement enqueue_after_transaction_commit #1310

Closed
luizkowalski opened this issue Apr 3, 2024 · 2 comments · Fixed by #1311
Closed

Adapter to implement enqueue_after_transaction_commit #1310

luizkowalski opened this issue Apr 3, 2024 · 2 comments · Fixed by #1311

Comments

@luizkowalski
Copy link
Contributor

hey Ben 👋🏻

I'm running an app on edge and noticed my jobs started failing after I updated Rails this afternoon. I tracked it down to this commit and I think Adapter should implement enqueue_after_transaction_commit? too
@bensheldon
Copy link
Owner

You noticed quick! Would you be willing to make a PR for that?

@luizkowalski
Copy link
Contributor Author

sure, let me play around with it a little bit

@luizkowalski luizkowalski mentioned this issue Apr 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
GoodJob Backlog v2
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement enqueue_after_transaction_commit? luizkowalski/good_job
2 participants
@bensheldon @luizkowalski