#good_job_labels retains values across job instances

[mhgoldman]

Given the following job:

class TestJob < ApplicationJob
  include GoodJob::ActiveJobExtensions::Labels

  before_enqueue { |job| job.good_job_labels << Time.now.to_s }

  def perform
    puts "#{good_job_labels}"
  end
end

Each job I enqueue contains the labels of the job before:

TestJob.perform_later # => ["2024-05-22 01:42:36 +0000"]
TestJob.perform_later # => ["2024-05-22 01:42:36 +0000", "2024-05-22 01:42:40 +0000"]
TestJob.perform_later # => ["2024-05-22 01:42:36 +0000", "2024-05-22 01:42:40 +0000", "2024-05-22 01:42:41 +0000"]

[bensheldon]

ooh, thanks for the report. I think there needs to be a dup in here:

good_job/lib/good_job/active_job_extensions/labels.rb

Line 11 in e632cf3

self.good_job_labels = Array(self.class.good_job_labels)

Let me try to make a quick repro test and fix.

[bensheldon]

Just released the fix for this: https://github.com/bensheldon/good_job/releases/tag/v3.29.2

[mhgoldman]

Fantastic. Many thanks for all your efforts!!