-
-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
undefined method `relative_time' when include_all_helpers is false #550
Comments
@shouichi thank you for reporting this! There's likely a lot of Rails configuration assumptions being made 😓 I can make a quick fix for this (explicitly requiring the helpers in the BaseController), unless you'd like to make the PR. |
Thanks for the reply! Sure, we can quickly fix it by explicitly including the helper. I have a small question before making that change. Can we rename BaseController to ApplicationController (which is more common I believe)? That way, we can follow the rails convention. |
Yep, BaseController can be renamed. I don't have much experience with Engine conventions, but change is easy 😊 |
Thanks for the feedback. I'll submit a PR! |
When
include_all_helpers
is set tofalse
, only a helper which matches the name of the controller is included.https://api.rubyonrails.org/classes/ActionController/Helpers.html
GoodJob engine defines some helpers in
ApplicationHelper
, thus only theApplicationController
(and its children) can access those helpers. Currently, the base controller is namedBaseController
and those helpers are not available.Thank you.
The text was updated successfully, but these errors were encountered: