Cleaning up preserved jobs giving me timeout

[murparreira]

Hey guys, thanks for the wonderful gem.
I am getting a timeout on my postgresql database when i run a task for deleting preserved jobs.
Right now we have more than 500k jobs succeeded.

This is the code inside the task.

GoodJob.cleanup_preserved_jobs(older_than: 1.days)

Can anyone point me in the right direction here?

[bensheldon]

@murparreira nuts! Can you tell me what your query timeout is?

I have a PR that I think might help. Would you be willing to try running that? #934

[murparreira]

This PR is just what i have implemented here.

This code worked and this change is very useful, as many applications uses a very tiny timeout due to performance or infrastructure needs.

[bensheldon]

I like the loop. I think that will result in one less query than using Active Record's in_batches.

[murparreira]

This PR #934, when merged fixes this problem.

[bensheldon]

@murparreira thank you for reporting this and the help fixing it! I released the change: https://github.com/bensheldon/good_job/releases/tag/v3.15.2

[murparreira]

@murparreira thank you for reporting this and the help fixing it! I released the change: https://github.com/bensheldon/good_job/releases/tag/v3.15.2

No problem! Happy to help.