Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation warning on the deprecation warning #943

Closed
zarqman opened this issue Apr 29, 2023 · 1 comment · Fixed by #945
Closed

Deprecation warning on the deprecation warning #943

zarqman opened this issue Apr 29, 2023 · 1 comment · Fixed by #945

Comments

@zarqman
Copy link
Contributor

zarqman commented Apr 29, 2023

FYI, on Rails 7.1 (on commit 912096d4ce93, which is HEAD as of now) with a pending GoodJob migration (such as the one just added in the 3.15.x series), I'm seeing the following deprecation warning about a change in ActiveSupport regarding deprecation warnings themselves:

ActiveSupport::DeprecationException: DEPRECATION WARNING: Calling warn on ActiveSupport::Deprecation is deprecated and will be removed from Rails (use your own Deprecation object instead) (called from migration_pending_warning! at ~/.rvm/gems/ruby-3.1.3@rails71/gems/good_job-3.15.6/app/models/good_job/base_record.rb:11)
~/.rvm/gems/ruby-3.1.3@rails71/bundler/gems/rails-912096d4ce93/activesupport/lib/active_support/deprecation/instance_delegator.rb:36:in `warn'
~/.rvm/gems/ruby-3.1.3@rails71/bundler/gems/rails-912096d4ce93/activesupport/lib/active_support/deprecation/instance_delegator.rb:50:in `warn'
~/.rvm/gems/ruby-3.1.3@rails71/gems/good_job-3.15.6/app/models/good_job/base_record.rb:11:in `migration_pending_warning!'

Reproducible in the Rails 7.1 console with:

ActiveSupport::Deprecation.warn('test')
@bensheldon
Copy link
Owner

@zarqman thank you! I think I can get that fixed real easy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants