Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseExecution::discrete_support? hardcodes the DiscreteExecution table_name #957

Closed
gap777 opened this issue May 19, 2023 · 3 comments
Closed

Comments

@gap777
Copy link
Contributor

gap777 commented May 19, 2023

It seems like the BaseExecution::discrete_support? is giving us a false answer, b/c we're using custom table names and this has the table_name for DiscreteExecution hardcoded.

Instead of base_execution.rb, L37 being:

     def discrete_support?
        if connection.table_exists?('good_job_executions')
          true
        else
          migration_pending_warning!
          false
        end
      end

I believe it should be

     def discrete_support?
        if connection.table_exists?(DiscreteExecution.table_name)
          true
        else
          migration_pending_warning!
          false
        end
      end

If you agree, I can open a PR.

Thanks, and keep up the great work!

@bensheldon
Copy link
Owner

Nice catch! Yes, please open a PR.

@gap777
Copy link
Contributor Author

gap777 commented May 19, 2023

#958 is open

@bensheldon
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants