Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure gradient norm is clipped #4

Open
BingyuZhou opened this issue Oct 26, 2020 · 0 comments
Open

Ensure gradient norm is clipped #4

BingyuZhou opened this issue Oct 26, 2020 · 0 comments

Comments

@BingyuZhou
Copy link

homework_fall2020/hw3/cs285/critics/dqn_critic.py

Line 91 in b5d3498

utils.clip_grad_value_(self.q_net.parameters(), self.grad_norm_clipping)

Should we use clip_grad_norm_ here?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BingyuZhou