Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paths are not escaped #102

Open
Niketin opened this issue Sep 22, 2024 · 0 comments
Open

Paths are not escaped #102

Niketin opened this issue Sep 22, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@Niketin
Copy link
Contributor

Niketin commented Sep 22, 2024

I tried to open OCP CAD Viewer. When it tried to launch the backend in the terminal, it failed because the path to the python interpreter contained spaces, and these spaces were not escaped. The path was interpreted as multiple arguments to the shell.

Commit: 7b1ac97

Steps to reproduce:
1.Have a virtual environment at a path that contains a folder "asd asd".
2. Open vscode.
3. Open the viewer.
4. It should result in an error on the terminal like follows:

/home/nikke/Documents/GBS mod cad/venv/bin/python /home/nikke/.vscode/extensions/bernhard-42.ocp-cad-viewer-2.4.1/ocp_vscode/backend.py --port 3940
zsh: no such file or directory: /home/nikke/Documents/GBS

I will create a pull request to fix this issue.

@bernhard-42 bernhard-42 added the bug Something isn't working label Sep 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants