Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShapeList of Compound displayed incorrectly #91

Closed
MatthiasJ1 opened this issue Aug 25, 2024 · 4 comments
Closed

ShapeList of Compound displayed incorrectly #91

MatthiasJ1 opened this issue Aug 25, 2024 · 4 comments

Comments

@MatthiasJ1
Copy link

x = Compound(children=[Circle(1), Pos(3)*Circle(1)])
x = ShapeList([x, Pos(Y=3)*x])

show_all()

Incorrect:
Screenshot 1

x, y = x # Expand list x into its components within separate variables

show_all()

Correct:
Screenshot 2

@bernhard-42
Copy link
Owner

Doesn't work in the latest version yet.
I never expected someone using ShapeList as a wrapper to generic lists.

x = Compound(children=[Circle(1), Pos(3)*Circle(1)])
x = [x, Pos(Y=3)*x]

show_all()

works in my latest version.

Out of curiosity, why are you doing this?

@MatthiasJ1
Copy link
Author

Well in my scenario I was projecting a sketch onto a solid which would give >1 Compounds which I was returning as a ShapeList to make it easy to sort/operate on. In this case Compounds made the most sense to me categorically but in general using unfused compounds can yield significant performance improvements.

@bernhard-42
Copy link
Owner

I now differentiate between (due to internal reasons) homogenous ShapeLists (as returned by e.g. edges()) and other ShapeLists. The other ones will simply be treated as lists and unrolled by the converter.

@bernhard-42
Copy link
Owner

fixed in 2.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants