Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring note. Placeholder. #56

Open
besok opened this issue Nov 22, 2023 · 0 comments
Open

Refactoring note. Placeholder. #56

besok opened this issue Nov 22, 2023 · 0 comments

Comments

@besok
Copy link
Owner

besok commented Nov 22, 2023

Placeholder to myself or somebody to find some time to refactor the module in the following points

  • replace all expect with ok_or(..)
  • refactor grammar (it feels like we need to squash some levels)
  • rewrite ast prasing. (it feels there is the implementation that heavily relies on the knowledge of the grammar itself which can be painful to handle in some cases)
  • ensure that all possible cases are covered with tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant