Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take advantage of slots #44

Open
bestguy opened this issue Sep 5, 2019 · 2 comments
Open

Take advantage of slots #44

bestguy opened this issue Sep 5, 2019 · 2 comments
Labels
Type: Refactor Enhancements, deletions, etc. to existing code

Comments

@bestguy
Copy link
Owner

bestguy commented Sep 5, 2019

We could probably improve many components by adding slot supports for headers, etc vs having to manually nest CardHeader, CardFooter, ToastHeader, alert-heading classes, etc.

@bestguy
Copy link
Owner Author

bestguy commented Oct 19, 2020

This idea won't be that useful until sveltejs/svelte#1037 is resolved, as currently this currently requires a wrapper html element like a div, etc:

<Card>
  <div slot="header">My Header</div>
  ...

Which doesn't seem any better than what we currently support:

<Card>
  <CardHeader>My Header</CardHeader>
  ...

@Maze-fr
Copy link

Maze-fr commented Apr 3, 2022

sveltejs/svelte#1037 has been closed one year ago.

@dysfunc dysfunc added Type: Refactor Enhancements, deletions, etc. to existing code and removed enhancement labels Nov 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Refactor Enhancements, deletions, etc. to existing code
Projects
None yet
Development

No branches or pull requests

3 participants