Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange configuration, motor and servo tab #2304

Closed
2 of 7 tasks
haslinghuis opened this issue Dec 4, 2020 · 9 comments · Fixed by #2356
Closed
2 of 7 tasks

Rearrange configuration, motor and servo tab #2304

haslinghuis opened this issue Dec 4, 2020 · 9 comments · Fixed by #2356

Comments

@haslinghuis
Copy link
Member

haslinghuis commented Dec 4, 2020

Feature Request: as suggested by @McGiverGim:

  • Move Mixer, ESC/Motor and 3Dfeatures to Motors TAB.
  • Move Servo test bars to Servos TAB.

Follow-up reminder:

  • Fix Rework 'Receiver' tab #81 (already done, only need cleanup after this PR is done)
  • Validate outputs with motor data after reboot and give a notice when there are to many outputs configured.
  • Dynamic display of motor test bars depending on available resources.
  • Redesign slider as suggested in this issue
  • Design a Parameter Group based loading/saving/polling mechanism for MSP.
@haslinghuis
Copy link
Member Author

haslinghuis commented Dec 23, 2020

Screenshots:

Configuration:
Screenshot from 2021-01-09 03-13-13

Servos:
Screenshot from 2021-01-08 02-35-26

Motors:
Screenshot from 2021-01-26 02-53-04

@haslinghuis haslinghuis changed the title Rearrange motor and servo tab Rearrange configuration, motor and servo tab Dec 23, 2020
@haslinghuis
Copy link
Member Author

haslinghuis commented Dec 26, 2020

There seems to be a bug I didn't notice before (also in 10.7 release):

Screenshot from 2020-12-26 16-07-07

@limonspb
Copy link
Member

What's wrong here?

@haslinghuis
Copy link
Member Author

Screenshot from 2021-01-02 12-11-55

@McGiverGim
Copy link
Member

Great work here! Is taking some time but the result is very good!

@mikeller
Copy link
Member

mikeller commented Jan 9, 2021

I am still not convinced that the square 'bars' and the tiny sliders are good UX.
I think if we arranged them side by side we'd actually make the slicers usable instead of 'pro forma' only.
Alternatively, if we don't think that users will want to use the sliders, we should remove them and replace them with numerical input fields, and use the space we gain to change the 'bars' to actually be bars and not squares.

@haslinghuis
Copy link
Member Author

@mikeller: The minimum size would only take about 30% width at full HD. So we could save a lot of space.

If we also move the notice below the test we now have a column on the right for the configuration section.

Screenshot from 2021-01-10 00-30-25

@mikeller
Copy link
Member

I prefer something along the lines of this - having both the sliders and the bars side-by-side seems to be much more conducive to represent them in the optimal form of being tall and narrow:

image (29)

@haslinghuis
Copy link
Member Author

Wow @asizon , this idea came from @limonspb any ideas?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants