Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssetServer:: load_with_settings ignores the settings if file was already loaded with default settings #11111

Open
stepancheg opened this issue Dec 27, 2023 · 1 comment
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@stepancheg
Copy link
Contributor

Example from this PR: https://github.com/bevyengine/bevy/pull/11109/files:

    let image = asset_server.load("textures/house_tree_river.png");

    let image_repeat = asset_server.load_with_settings(
        "textures/house_tree_river_copy.png",
        ...
    );

if we use the same file name, second image will ignore the settings (ImageAddressMode to be specific). Here we are using a workaround: providing a different file name.

@stepancheg stepancheg added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Dec 27, 2023
@alice-i-cecile alice-i-cecile added A-Assets Load files from disk to use for things like images, models, and sounds and removed S-Needs-Triage This issue needs to be labelled labels Dec 27, 2023
@JMS55 JMS55 added this to the 0.13 milestone Dec 28, 2023
@mockersf
Copy link
Member

seems to me asset settings should be part of the handle

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Bug An unexpected or incorrect behavior S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Development

No branches or pull requests

4 participants