Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check-missing-*-in-docs job does not install Rust #13039

Open
BD103 opened this issue Apr 20, 2024 · 1 comment
Open

check-missing-*-in-docs job does not install Rust #13039

BD103 opened this issue Apr 20, 2024 · 1 comment
Labels
A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy

Comments

@BD103
Copy link
Member

BD103 commented Apr 20, 2024

In ci.yml, both check-missing-examples-in-docs and check-missing-features-in-docs do not install Rust before running it. This means that they are instead using the implicitly installed Rust tools that come with the ubuntu-latest image.

This is an issue because the image versions of Rust may not update in lockstep with the rest of the Bevy project. Our current MSRV policy is "latest stable." If the image installation is behind, it may cause the jobs to spuriously fail.

To fix this, dtolnay/rust-toolchain@stable should used. See other jobs such as build for reference.

check-missing-examples-in-docs:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- uses: actions/checkout@v4
- name: check for missing metadata
id: missing-metadata
run: cargo run -p build-templated-pages -- check-missing examples
- name: check for missing update
run: cargo run -p build-templated-pages -- update examples

check-missing-features-in-docs:
runs-on: ubuntu-latest
timeout-minutes: 30
needs: check-missing-examples-in-docs
steps:
- uses: actions/checkout@v4
- name: check for missing features
id: missing-features
run: cargo run -p build-templated-pages -- check-missing features

@BD103 BD103 added C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy A-Build-System Related to build systems or continuous integration labels Apr 20, 2024
@BD103
Copy link
Member Author

BD103 commented Apr 22, 2024

I'm going to wait for #13040 to be merged before working on this, so we can immediately use the new cache system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Build-System Related to build systems or continuous integration C-Bug An unexpected or incorrect behavior D-Trivial Nice and easy! A great choice to get started with Bevy
Projects
None yet
Development

No branches or pull requests

1 participant