Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Import Lights from GLTF #1331

Closed
inodentry opened this issue Jan 27, 2021 · 3 comments
Closed

Import Lights from GLTF #1331

inodentry opened this issue Jan 27, 2021 · 3 comments
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Feature A new feature, making something new possible

Comments

@inodentry
Copy link
Contributor

Currently, the GLTF loader loads meshes, textures, materials, scenes ... but it does not load lights.

Why that limitation? Can we load lights from GLTF?

@FrankenApps
Copy link

Loading lights from a GLTF requires the KHR_lights extension.
See this Issue for further information.
That means it is not in the standard spec for GLTF 2.0.

The gltf crate does however support at least the KHR_lights_punctual extension, so I guess support for punctual lights could be added pretty effortlessly.
However I do not know, why it has not been done yet.

Apart form that, it seems to me, that because of this answer, that only punctual, directional and spot lights can be included and no ambient lights. Since bevy does not support directional or spot lights (correct me if I am wrong) the only supported light type would be punctual lights.

@karroffel karroffel added A-Assets Load files from disk to use for things like images, models, and sounds C-Feature A new feature, making something new possible labels Jan 30, 2021
@james7132
Copy link
Member

This seems to at least be partially resolved as of #4715. Are we still missing anything for this issue?

@inodentry
Copy link
Contributor Author

Bevy has supported Directional, Point, and Spot lights for some time now, and looking through the bevy_gltf code right now I see that they are all being loaded. It seems like it should all be resolved.

Closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Assets Load files from disk to use for things like images, models, and sounds C-Feature A new feature, making something new possible
Projects
None yet
Development

No branches or pull requests

4 participants