Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PhantomData does not implement Reflect #5144

Closed
alice-i-cecile opened this issue Jun 30, 2022 · 2 comments
Closed

PhantomData does not implement Reflect #5144

alice-i-cecile opened this issue Jun 30, 2022 · 2 comments
Labels
A-Reflection Runtime information about types C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Wontfix This issue is the result of a deliberate design decision, and will not be fixed

Comments

@alice-i-cecile
Copy link
Member

What problem does this solve or what need does it fill?

PhantomData is a common and useful type, it should implement the Reflect trait.

Users cannot do this themselves because of orphan rules, and wrappers are very frustrating here.

What solution would you like?

Implement Reflect for PhantomData in bevy_reflect.
@alice-i-cecile alice-i-cecile added D-Trivial Nice and easy! A great choice to get started with Bevy C-Usability A targeted quality-of-life change that makes Bevy easier to use A-Reflection Runtime information about types labels Jun 30, 2022
@Gingeh Gingeh mentioned this issue Jun 30, 2022
Closed
@aevyrie aevyrie mentioned this issue Nov 13, 2022
Closed
@BenjaminBrienen
Copy link
Contributor

You can assign this one to me

@BenjaminBrienen BenjaminBrienen mentioned this issue Sep 19, 2024
Closed
@BenjaminBrienen BenjaminBrienen added the S-Wontfix This issue is the result of a deliberate design decision, and will not be fixed label Oct 10, 2024
@BenjaminBrienen BenjaminBrienen removed their assignment Oct 10, 2024
@BenjaminBrienen
Copy link
Contributor

A better solution has been suggested to instead have a way to automatically ignore marker types.

@BenjaminBrienen BenjaminBrienen closed this as not planned Won't fix, can't repro, duplicate, stale Oct 10, 2024
@BenjaminBrienen BenjaminBrienen mentioned this issue Oct 10, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Reflection Runtime information about types C-Usability A targeted quality-of-life change that makes Bevy easier to use D-Trivial Nice and easy! A great choice to get started with Bevy S-Wontfix This issue is the result of a deliberate design decision, and will not be fixed
Projects
Reflection
Status: Done
Milestone
No milestone
2 participants
@alice-i-cecile @BenjaminBrienen