New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incomplete support for RFC9069 (local RIB in BMP) #164

Open

1 of 2 tasks

digizeph opened this issue Apr 10, 2024 · 1 comment

Open

1 of 2 tasks

Incomplete support for RFC9069 (local RIB in BMP) #164

digizeph opened this issue Apr 10, 2024 · 1 comment

Labels

rfc

Milestone

Member

digizeph commented Apr 10, 2024 •

edited

Loading

https://www.rfc-editor.org/rfc/rfc9069

Incomplete checks and features includes:

checks for the fields that must be set for LocalRIB type messages, e.g. https://www.rfc-editor.org/rfc/rfc9069#name-per-peer-header-2
Peer-flags is different from regular BMP per-peer header and thus we should definine a separate type for this: https://www.rfc-editor.org/rfc/rfc9069#section-4.2

Member Author

digizeph commented Apr 10, 2024

Per-peer-flag is already implemented for LocalRIB:

bgpkit-parser/src/parser/bmp/messages/headers.rs

Lines 137 to 140 in 6a3bca1

    
           pub enum PerPeerFlags { 
        
               PeerFlags(PeerFlags), 
        
               LocalRibPeerFlags(LocalRibPeerFlags), 
        
           }

digizeph added this to the V1.0 milestone

digizeph added the rfc label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment