Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<nowiki> not working with link syntax #14

Open
joelittlejohn opened this issue Oct 31, 2019 · 1 comment
Open

<nowiki> not working with link syntax #14

joelittlejohn opened this issue Oct 31, 2019 · 1 comment

Comments

@joelittlejohn
Copy link

joelittlejohn commented Oct 31, 2019

The <nowiki> tag doesn't quite function correctly with this extension active, in particular when used with the mediawiki links syntax.

An example of the problem is shown on the Special:Upload page. Instead of seeing the correct markup help, I see this:

image

When we should be seeing:

  • [[File:File.jpg]] to use the full version of the file

etc

This seems to be because Markdown.php calls $parser->replaceInternalLinks($html) without any attempt to escape things that are inside a <nowiki> tag.

Ideally I'd like to escape <nowiki> content before processing these links, but I can't find any simple function to call in the parser to make this happen 😞

I'd love to help fix this up if anyone has any ideas about where to start.

@joelittlejohn
Copy link
Author

For Special:Upload I worked around this by adding {{WIKI}} to the start of the page. I then also had to create an empty Template:WIKI to avoid the red text "Template:Wiki" being shown in my page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant