Compile fails to terminate in very specific circumstances #377
Comments
|
Oof - it turns out I can actually repro this on macOS 10.15.2 too - rust 1.41 fails to finish compiling criterion.rs: |
|
Here's the `cargo bench --verbose``rustc --version```` rustc 1.41.0 (5e1a79984 2020-01-27) ``` |
|
I would leave a few notes here.
nonzero!(u32::max_value()); |
|
Well oof, now I feel like a real fool. First, oops - I didn't realize that it was the benchmark module itself that failed to compile... on circleci, it did look like the crate itself was looping. And second, this is actually a bug reported to rust by myself, and fixed a month ago: rust-lang/rust#67539. Ouch. I think we can close this, but I'll raise the issue with the rust folks. Seems like stable shouldn't have picked up the broken change? |
|
No worries! I'm glad you figured out your problem, and thanks for trying Criterion.rs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi folks, starting with stable
rustc 1.41.0 (5e1a79984 2020-01-27), I'm seeing the criterion.rs compile step hang on circleci when preparing to benchmark my crate.Here's a typical run: https://app.circleci.com/jobs/github/antifuchs/governor/623 - you'll notice that the criterion compile task took 10min (I bumped the time limit to 20min once, and it still didn't finish).
Now, I'm not certain what exactly is causing the compile to not terminate, but it's only criterion and only on circleci that it fails to terminate.
Further diagnostics
I've ssh'ed into the build worker and tried to see what's actually hanging. The process that seemed hung was this (sorry for the gross way this is presented - the build container doesn't have convenient things like
psand such):This process has two tasks, one sleeping and one permanently running.
Works on
nightlyChanging the rustc version to
nightlyseems to unblock the compile task: https://app.circleci.com/jobs/github/antifuchs/governor/633 finishes compiling within seconds and then runs the actual benchmarks.The text was updated successfully, but these errors were encountered: