Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing default for argument minloadcrit? #34

Closed
vincentvanhees opened this issue May 2, 2024 · 1 comment · Fixed by #37 or #39
Closed

changing default for argument minloadcrit? #34

vincentvanhees opened this issue May 2, 2024 · 1 comment · Fixed by #37 or #39

Comments

@vincentvanhees
Copy link

vincentvanhees commented May 2, 2024

It may be good to bring to your attention that I am changing the default argument minloadcrit value in GGIR from 72 to 168. See description and motivation in wadpac/GGIR#1101

This will slow down the auto-calibration procedure but seems worth it when user wants to rely on ENMO metric. On the other hand, the results I present in that issue indicate also that for other metrics we may be fine with less than 72 hours of data or skipping the auto-calibration entirely as we already hinted at in the 2014 publication. So, it may be worth exploring whether a more clever setting of minloadcrit depending on acceleration metrics to be derived could optimise processing time without compromising the output.

@bhelsel
Copy link
Owner

bhelsel commented May 20, 2024

Thanks Vincent! I'm making this change in the most recent version of the agcounts R package so it matches your updates to the GGIR package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants