Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IE support #1

Open
javitamara opened this issue Aug 29, 2014 · 2 comments
Open

IE support #1

javitamara opened this issue Aug 29, 2014 · 2 comments

Comments

@javitamara
Copy link

First let me say congratulations, this calendar was just what I was looking for, great job!
I know that IE is annoying! but have you tried the full year calendar on IE 8?
http://bichotll.github.io/bic_calendar_full/
Any clue on what could be the reason is not working on IE?

@bichotll
Copy link
Owner

Hey! Thanks then ;)

Well, in theory, and as far as I remember, Bic Calendar should work but the headers on IE8. And I did not work so much more with it cause I did not have the need.
Now, in this version is because I'm loading the jQ version 2.. I guess that if you change it for the 1. it will work fine.

On the other hand, you will also have to deal with the TwBootstrap IE compatibilities. This example is using the version 3.*.
For more information: http://getbootstrap.com/getting-started/#support

About the example's jQ library:
https://github.com/bichotll/bic_calendar_full/blob/master/example/lib/js/jquery.js

btw, if you like it, spread the faith of it staring it ;)
n as always, if you solve it and wanna collaborate, fork it or explain here how ;)

Cheers

@javitamara
Copy link
Author

Thanks for you reply! The issue wasn't related with the JQ versión (I'm using v 1.11.0) neither the bootstrap framework. I tracked the error following the js alerts and then started to comment the lines related, first I had to comment line 392 on bic_calendar.js:

//class
if (events[i].class)
loopDayTd.addClass(events[i].class);

Then commented the line: class: ' ', on every event I created on my html.

After that, the calendar was displayed on ie 8 and didn't give me any js error.

Before commenting those lines I tried to define a name for the class in every event but it didn't work.

I'm not developer, so I can't tell you the cause of this issue but I hope this information will be helpful.

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants