-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Say No to symbolic links! not needed IMHO #82
Comments
Hi @yarikoptic , Thanks for your interest in BEP-001. We have the following problem: In quantitative MRI, we often want to calculate a "quantitative map", that is based on a number of MR images. For example, in the case of MP2RAGE, we can get a T1 map and a T1-weighted "UNI"-image, without B0 and B1 inhomogenieties. Sometimes we calculate these maps ourselves. Sometimes, they "roll right out" of the scanner. Importantly, we often want to use these quantitative maps in further processing. For example, the In the current way BIDS works, it seems there is no way for BIDS apps to use data from the Cheers, |
I'm curious how this was determined. Is there some text in the specification that specifically prevents it? fMRIPrep uses FreeSurfer derivatives found in the output directory (which may or may not be Or do you mean that the existing pipelines will not know to index derivatives? Given that a derivative dataset may include any source data it chooses, one option would be simply to make a directory that contains these a conformant derivatives dataset. |
Can you elaborate a bit on how this would work for the MP2RAGE/T1UNI example? |
Even with all my git-annex rotten soul I must say that BIDS must stay away from any filesystem features beyond having directories and files in them. And I think symbolic linking for some hypothetical purity is simply not needed here. One of my arguments is that BIDS itself, although intended for "raw" data, is containing "derived" data already in 99% of the cases:
sourcedata/
hints on that data in BIDS dataset is not the "source" one, but converted (and thus derived) one way or another from source data (DICOMs)so I do not think it is productive to try making it 100% explicit by placing "minimally processed" data into
derivatives/
and then symlinking to establish the origin. BIDS does even somewhat "allows" for it:so if outside-of-scanner processing is needed to derive a file, it is really close to "file format conversion". If such processing is more than un-ambiguous conversion/computation which could be parametrized, then it should be done and reflected in "BIDS common derivatives" fashion (BEP003 PR), e.g. by using
_desc-
field and all provenance tracking (BasedOn introduced in #59) should be "worked out" on "common derivatives" level.The text was updated successfully, but these errors were encountered: