Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

motion: clarify "latency" channel type description #1462

Closed
sappelhoff opened this issue Apr 5, 2023 · 1 comment · Fixed by #1464
Closed

motion: clarify "latency" channel type description #1462

sappelhoff opened this issue Apr 5, 2023 · 1 comment · Fixed by #1464
Milestone

Comments

@sappelhoff
Copy link
Member

Regarding the comment from @sappelhoff about latency channel, yes, the onset is intended to be the acq_time of scans.tsv and the text could be updated to make that clear.
That would also imply that the first sample should always have latency of 0, considering acq_time = when the first data point in each run was acquired.

ss[.000000] was not intended to imply integer digit limit. But I see how it is misleading.
Should we update the notation to s[.000000] and add that s refers to an integer of arbitrary number of digits?

Originally posted by @sjeung in #1436 (comment)

This issue is to explicitly track these points which came up in another thread. Just to prevent this from being buried and forgotten, as it's important.

Related to:

@sappelhoff sappelhoff added this to the 1.9.0 milestone Apr 5, 2023
@JuliusWelzel
Copy link
Collaborator

See my solution at #1464. Is there a different file where the latency channel description should be edited, for example in the schema?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants