Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup a no-bad-latin github action #635

Closed
Remi-Gau opened this issue Oct 1, 2020 · 1 comment · Fixed by #636
Closed

Setup a no-bad-latin github action #635

Remi-Gau opened this issue Oct 1, 2020 · 1 comment · Fixed by #636

Comments

@Remi-Gau
Copy link
Collaborator

Remi-Gau commented Oct 1, 2020

On related issue: would it make sense to "install" the github action used by the Turing way to check our content for Latin expressions to ensure we don't have to redo this in the future?

probably worth looking into, good idea! 👍 we'd have to clarify what else they are linting / checking, and make sure that all of these steps are (or can be) configured to our liking.

If you have time and interest to do that, I'd appreciate a short report and potentially a new PR :-)

Originally posted by @sappelhoff in #628 (comment)

Opening this issue with the links to the action and its script.

Github action workflow:
https://github.com/alan-turing-institute/the-turing-way/blob/master/.github/workflows/no-bad-latin.yml

Python script called by action:
https://github.com/alan-turing-institute/the-turing-way/blob/master/tests/no-bad-latin.py

Point to figure out if we decide to use it:

  • crediting the person who wrote this code.
@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Oct 1, 2020

From a look at the python script it should be fairly adaptable to our needs: I think it is mostly a matter of poiting to different folders and specifying what expression to look for

I can work on that but if I don't make it for the 1.4.1 deadline don't wait for me. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant