Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python script to generate MP2RAGE json #99

Closed
Remi-Gau opened this issue Oct 3, 2018 · 3 comments
Closed

python script to generate MP2RAGE json #99

Remi-Gau opened this issue Oct 3, 2018 · 3 comments
Labels
enhancement requests to add something new to the project question questions waiting for an answer

Comments

@Remi-Gau
Copy link
Collaborator

Remi-Gau commented Oct 3, 2018

Hey,
I have recently written my first python script that did not blow up my house and it was made to create the MP2RAGE json files for my BIDS data sets (to fit the way they are described in the current state of the BIDS extension).
I am wondering if there is any point of adding this script to this repo as this extension is not finalized yet as as we seem to have a json scripts inflation issue that needs for uniformization (#47 #57 #58 ).
@+
Remi

@KirstieJane
Copy link
Member

Hi @Remi-Gau!

You're right that we haven't quite formalised #57 but I think more is better than less to get started. For example the harmonise across languages issue #58 makes the most sense if there are a few to harmonise!

I also feel the same way about having tools that are for extensions - in my opinion its the more the merrier at this stage....but maybe add the date to a comment at the top of the file and highlight that the spec may change and therefore this may end up being out of date?

@KirstieJane KirstieJane added enhancement requests to add something new to the project question questions waiting for an answer labels Oct 3, 2018
@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Oct 3, 2018

OK I will make a pull request after I have cleaned the code a bit: at least this way we will have more material. And very good idea about the comment/warning about in the script !

@emdupre
Copy link
Collaborator

emdupre commented Nov 2, 2018

I think this is good to close with the merge of #101 !

@Remi-Gau Remi-Gau closed this as completed Nov 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement requests to add something new to the project question questions waiting for an answer
Projects
None yet
Development

No branches or pull requests

3 participants