Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MRI schemas bold.json etc. #1074

Open
sappelhoff opened this issue Sep 17, 2020 · 0 comments
Open

Add MRI schemas bold.json etc. #1074

sappelhoff opened this issue Sep 17, 2020 · 0 comments
Labels
effort: high Estimated high effort task impact: high Estimated high impact task json-schema All issues that involve work with the JSON-schema files

Comments

@sappelhoff
Copy link
Member

sappelhoff commented Sep 17, 2020 •
edited
Loading

The MRI JSON schemas are currently not exhaustively specified, currently there is only a bold.json schema: https://github.com/bids-standard/bids-validator/tree/master/bids-validator/validators/json/schemas

yet in bids-examples, I see many more MRI jsons like

  • phasediff.json
  • T1w.json
  • T2w.json
  • dwi.json
  • epi.json
  • sbref.json

and there are probably more. I think we should:

that will significantly improve validation and also address issues like #851 and clarify #1044

I am not an expert with this type of data, so I'd appreciate if someone else could do a PR for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort: high Estimated high effort task impact: high Estimated high impact task json-schema All issues that involve work with the JSON-schema files
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sappelhoff