-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SCHEMA] physio and stim not included for EEG, MEG, iEEG and PET #1412
[SCHEMA] physio and stim not included for EEG, MEG, iEEG and PET #1412
Comments
pinging @tsalo 😉 |
actually the physio page says this:
So I suspect that PET should not be included but some other datatypes should be included. This might make make the templates of some section complicated to read: for example the one for anat. |
On this topic: @mnoergaard @melanieganz should PET support physio / stim recording ? Or is it like supporting task for PET? See this comment: bids-standard/bids-specification#804 (comment) |
It seems like it should. Should also check in about ASL. |
That should be fine,as this doesn't significantly change the ASL specification, as far as i understand now? We decided however not to support functional ASL yet as this would require all non task ASL (99% of ASL data) to include Physiological simuli are more common in ASL, in the form of an acetazolamide challenge, breath hold, or CO2 challenge. Would this be covered by physio/stim? |
@HenkMutsaerts @Remi-Gau Indeed, functional ASL might get implemented later on. If I understand correctly, it was now mainly an issue to get it working in the validator. Marco might remember this. |
yeah this would be one of the most straightforward way of gas concentration and respiration during your acquisition and it does not need to change anything to the part of ASL spec. We just need mention the physion / stim page that ASL supports it. |
If you are referring to the fact that physio files in the |
I suggest implementing this in several PRs split up by datatypes with a counterparts on the validator side.
|
OK I will wait for the bids-standard/bids-specification#883 to be in before opening PRs on this to avoid potential merge conflicts. |
Will actually transfer this to the validator to remember to implement it. |
I think this is done. If it's not, please open a new issue with a clearer requirement. |
physio
andstim
suffixes are currently included for func and beh.But they are not included for the following data types:
Implement validation for validator:
I can't think of a reason for why that's the case, should we add those to the schema ?
The text was updated successfully, but these errors were encountered: