Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xml2js is breaking the deno build #2105

Closed
effigies opened this issue Aug 22, 2024 · 0 comments · Fixed by #2106
Closed

xml2js is breaking the deno build #2105

effigies opened this issue Aug 22, 2024 · 0 comments · Fixed by #2106

Comments

@effigies
Copy link
Collaborator

effigies commented Aug 22, 2024

There's no winning with these dependencies.

FYI I wanted to try it out and used the command as in #2081 (comment) and got this error:

docker run -ti --rm -v $PWD:/data:ro denoland/deno deno run --allow-read --allow-env --reload -A https://github.com/bids-standard/bids-validator/raw/deno-build/bids-validator.js /data
error: Uncaught (in promise) Error: Dynamic require of "events" is not supported
  throw Error('Dynamic require of "' + x + '" is not supported');
        ^
    at https://raw.githubusercontent.com/bids-standard/bids-validator/deno-build/bids-validator.js:12:9
    at Object.<anonymous> (https://raw.githubusercontent.com/bids-standard/bids-validator/deno-build/bids-validator.js:11:12)
    at ../../../../.cache/deno/deno_esbuild/[email protected]/node_modules/xml2js/lib/parser.js (https://raw.githubusercontent.com/bids-standard/bids-validator/deno-build/bids-validator.js:395:4)
    at __require3 (https://raw.githubusercontent.com/bids-standard/bids-validator/deno-build/bids-validator.js:15:50)
    at Object.<anonymous> (https://raw.githubusercontent.com/bids-standard/bids-validator/deno-build/bids-validator.js:12:12)
    at ../../../../.cache/deno/deno_esbuild/[email protected]/node_modules/xml2js/lib/xml2js.js (https://raw.githubusercontent.com/bids-standard/bids-validator/deno-build/bids-validator.js:39:4)
    at __require3 (https://raw.githubusercontent.com/bids-standard/bids-validator/deno-build/bids-validator.js:15:50)
    at https://raw.githubusercontent.com/bids-standard/bids-validator/deno-build/bids-validator.js:6:25

Originally posted by @mateuszpawlik in #2091 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant