Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Breakpoint width measurement off. Doesnt take scrollbar into account #46

Closed
adamrobinson opened this issue Sep 20, 2018 · 4 comments
Closed

Breakpoint width measurement off. Doesnt take scrollbar into account #46

adamrobinson opened this issue Sep 20, 2018 · 4 comments

Comments

@adamrobinson
Copy link

It's proving hard to match up the breakpoint values in the plugin with CSS breakpoint values because of the way screen width is calculated.

Testing In Chrome the breakpoint in the plugin triggers 15px wider than the CSS media query (sizing window up). 15px seems to be the exact size of the scrollbar.
@jrmd
Copy link
Member

jrmd commented Sep 20, 2018

Hey @adamrobinson

Sorry you're having issues with this, I have a fix in mind so I will do some tests and should have fix sorted by tonight

@jrmd
Copy link
Member

jrmd commented Sep 20, 2018

Hey @adamrobinson this issue has been resolved in version 2.3.1

Let me know if you have any issues with the build.

@jrmd jrmd closed this as completed Sep 20, 2018
@adamrobinson
Copy link
Author

Thank you @jrmd for such a quick fix it’s really appreciated. Will test out the new version first thing in the morning.

@adamrobinson
Copy link
Author

Works great now. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adamrobinson @jrmd