-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AUX images support #117
Comments
Hello. I'm trying to get the HDR gain map aux image, and I see aux image support is yet to be implemented...
Why non- |
No, at the moment AUX images are not supported (I don't want to write a conversion from 16/12/10 bit images to 8 bit for them) - I'm waiting for Pillow to support HDR images, they seem to be working on it. As soon as Pillow starts supporting RGB(a) 10/12/16 bit, pillow_heif will immediately be refactored and support for AUX and other things will appear. |
Are you saying that once Pillow supports HDR images, If that's what you meant, I wasn't referring to that. I simply wanted to read the HDR gain map as is, independently from the SDR image. From what I can see, |
definitely yes, but I myself don't want to add reading of only part of AUX images (for example, add reading of I myself will only have time for the final refactoring, when Pillow will support this: if you want and you have time, I will gladly accept and test the PR for this, even for supporting only part of the AUX image variants. |
Great! I do have some time and started digging in https://github.com/johncf/pillow_heif/tree/aux-images For now, I made a change that exposes all aux images through
|
|
I made a PR (#297) with a slightly different approach that doesn't give any special treatment to Apple's way of doing things. Out of topic: If you like that approach of doing things (i.e., expose only a list of IDs from the |
Thank you for making PRs, I will review them tomorrow or a day after and ping you of course |
Divided #83 topic into two separate.
Briefly: I can easy add AUX image support whenI will have any non iPhone image, with different
auxiliary_type
(e.g. nonhdrgainmap
)Or when I get information from here: strukturag/libheif/issues/926
Currently we can not determine image mode, and I need to know, can all aux images be decoded as grayscales ones or not.
Cause if not, then algorithm will be a little bit weird, need first to try to decode as Greyscale and if decodes fails, then decode it as RGB/RGBA...
The text was updated successfully, but these errors were encountered: