TODOs

[TimDaub]

What's left to be done:

• Preferably an IPFS/IPLD expert reviews the code
• Preferably a Python expert reviews the code
• Include support for Multiaddr (+ implementations: https://github.com/sbuss/py-multiaddr, https://github.com/amstocker/python-multiaddr)
• Put package on PyPI
• Setup Travis
• Setup Codecov
• Upgrade version of pymultihash to non-forked version
• ipld.multihash should allow passing in different functions ipld/js-ipld-dag-cbor#15
• Write a test to cover this last untested line (https://github.com/bigchaindb/py-ipld/blob/master/ipld/ipld.py#L26)
• Library should accept raw Multiaddr objects (instead of ones that are casted using str()): Add multiaddr support #10 (comment)

[dignifiedquire]

Preferably an IPFS/IPLD expert reviews the code

I have written the JavaScript implementation and have enough python knowledge to review python code. I'm travelling the next two days, but I can review it on Friday probably.

[TimDaub]

Preferably a Python expert reviews the code

@sbellem told me he'd like to do it.

[jbenet]

I'd probably leave the multiaddr support to another module. or did you mean multihash? (sorry we have so many 😄 )

[TimDaub]

I'd probably leave the multiaddr support to another module. or did you mean multihash? (sorry we have so many )

I meant multiaddr. I think we're aligned though:

• There is py-multiaddr (doesn't exist yet, but will eventually) which is basically an implementation of your spec of multiaddr in Python
• There is py-ipld (this lib) that uses py-multiaddr (as a dependency) for ipld links

So when I say "Include support for Multiaddr", I mean the second point (which includes doing the first point).

OK?

EDIT:

As @fredthomsen pointed out, there are already two implementations of multiaddr:

• https://github.com/sbuss/py-multiaddr
• https://github.com/amstocker/python-multiaddr

[sbellem]

note: the package has been registered on PyPI: https://pypi.python.org/pypi/ipld/0.0.1

I propose to use the simpler name ipld for PyPI/python. So python users can simply install it using the same name as the module:

$ pip install ipld

import ipld

[fredthomsen]

@TimDaub there are actually two python implementations of py-multiaddr already implemented that could be leveraged/added as dependencies by this library for the ipld links.

• https://github.com/sbuss/py-multiaddr
• https://github.com/amstocker/python-multiaddr

[TimDaub]

@TimDaub there are actually two python implementations of py-multiaddr already implemented that could be leveraged/added as dependencies by this library for the ipld links.

Multiaddr support has been added with #10

[TimDaub]

Put package on PyPI

Package was just released on pypi :)
Thx @sbellem