fix(component): only focus on TreeItem when focus within Tree component #1087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanceaclark
force-pushed
the
fix/tree-focus
branch
from
e7f1e23
to
9b2957a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Focuses on the
TreeItemwhenever thedocument.activeElementis within theTree.Also, updates
Treetests to reflect better testing patterns (see #635).Why?
This fixes the behavior we've seen for a while which causes the tree to be initially focused on initial render. This causes some accessibility concerns as the we place the user onto the tree instead of the initial page or, in the case of modals, launch order.
Screenshots/Screen Recordings
Screen.Recording.2023-01-04.at.12.39.44.mov
Screen.Recording.2023-01-04.at.11.56.55.mov
Testing/Proof
Added two additional tests, along with updating the
Treetests to reflect better testing patterns.Closes #801