Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Stencil] Update handlebars reverse helper link #2059

Merged
merged 1 commit into from
Aug 30, 2023

Conversation

jairo-bc
Copy link
Contributor

@jairo-bc jairo-bc commented Aug 30, 2023

[DEVDOCS-]

{Ticket number or summary of work}
Reverse helper currently doesn't support array's type. Our documentation is correct, but the link goes to the old codebase, which is not fully correct (currently it says that supports string and arrays, but actually only strings are supported) and makes confusion

What changed?

Updated reverse helper link to our codebase

ping @bigcommerce/dev-docs @bigcommerce/team-storefront @bc-evan-johnson

Copy link
Contributor

@bc-traciporter bc-traciporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bc-traciporter bc-traciporter merged commit 49b6332 into main Aug 30, 2023
2 checks passed
@bc-traciporter bc-traciporter deleted the replace-link-reverse branch August 30, 2023 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants