Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No helper to strip Html Tags from Content String #122

Open
fthobe opened this issue Nov 28, 2020 · 1 comment
Open

No helper to strip Html Tags from Content String #122

fthobe opened this issue Nov 28, 2020 · 1 comment

Comments

@fthobe
Copy link

fthobe commented Nov 28, 2020

=== Issue ===
In certain scenarios it can be beneficial SEO to link internally via product descriptions. Given that the product descriptions are also used to generate the .json for structured data it might happen that the description breaks the .json.

@Tiggerito
Copy link

Same goes for any field users can input html.

And all fields should be made json safe. i.e. encode quotes. This can be tricky as the last time I used {{{json property}}} it would return nothing if the property was blank, breaking the syntax.

Another less known issues is if the html includes a closing script tag. This breaks out of a script even if the text is inside a string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants