Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

money.js money.currency_location not working properly #142

Open
HeartexceL opened this issue Jul 15, 2021 · 2 comments
Open

money.js money.currency_location not working properly #142

HeartexceL opened this issue Jul 15, 2021 · 2 comments

Comments

@HeartexceL
Copy link

looks like the money.currency_location aren't working at least on my build for some reason.
it always show 'right' even though the store settings currency config is 'left'.
ie:
{{money 1000 2 ',' '.'}}
1,000.00$

can anyone confirm this?

file: https://github.com/bigcommerce/paper-handlebars/blob/master/helpers/money.js

@HeartexceL HeartexceL changed the title money.js money.currency_location not working money.js money.currency_location not working properly Jul 15, 2021
@jcoerin
Copy link

jcoerin commented Feb 22, 2022

I can confirm this. The issue is that on line 35 the {{money}} helper is comparing the settings.money.currency_location value against 'left' (lowercase), but the theme settings store the settings.money.currency_location value in title case (e.g. "Left" instead of "left"). I verified the money.currency_location casing by printing it out using the {{json}} helper.

@manojxumulus
Copy link

Hello,

Any resolution to this issue?

I am facing the same issue and waiting for any solution.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

3 participants