Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default "to" is not taken into account when a non-default "from" currency is used #14

Open
durmaze opened this issue Nov 2, 2015 · 5 comments

Comments

@durmaze
Copy link

durmaze commented Nov 2, 2015

Hi,

nice workflow!

after setting the default from and to currencies, when i tried to use a different currency for the "from", it didnt use the default "to" currency i set up. instead, it uses the USD.

may be it is by design, but i would expect to use the default "to" currency.

thanks

@arvidbjorkstrom
Copy link

In fact, it doesn't explicitly use USD, it uses your default from currency. I'm guessing you have your default to currency set to USD. :)

@dixhuit
Copy link

dixhuit commented Mar 14, 2016

I'm seeing this too. My "default to" is set to GBP but typing "currency AUD" shows me a conversion to USD.

@idiotWu
Copy link

idiotWu commented Jul 26, 2016

I guess the problem is caused from here: e4QueryParser.php#L129.

Changing it into the following will fix this issue:

$this->to = $this->from->isEqualOf($this->defaultTo) ? $this->defaultFrom : $this->defaultTo;

@Talzoor
Copy link

Talzoor commented Dec 16, 2016

It is fixing this issue. great!
Thank you idiotWu.

@jorgenbs
Copy link

Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants