Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to make corner Bed leveling use the Correct Dimensions of my Printer? #2128

Closed
XoBoR opened this issue Aug 17, 2021 · 8 comments · Fixed by #2133
Closed

How to make corner Bed leveling use the Correct Dimensions of my Printer? #2128

XoBoR opened this issue Aug 17, 2021 · 8 comments · Fixed by #2133
Labels
question Further information is requested

Comments

@XoBoR
Copy link

XoBoR commented Aug 17, 2021

Greetings,

I'm trying to make corner bed leveling work, however it does not use the correct bed dimensions, instead it uses the default values of 235x235x250.

The documentation states:

The TFT will auto-detect the machine size (min and max) in Marlin firmware (requires enabling M115_GEOMETRY_REPORT in Configuration_adv.h in Marlin firmware)

I have enabled M115_GEOMETRY_REPORT in my Marlin firmware, and going through the Terminal of my TFT70 I can see that it is reporting the correct dimensions of my Printer.

I have tried to set the correct Dimensions manually in Configuration.h, but the values I've put in are being ignored.

I have tried comment out Dimensions in config.ini, no change.

Putting the correct values in config.ini does work, but still, why isn't the TFT using the dimensions reported by the board?

Is this a Bug or am I missing something?

@XoBoR XoBoR added the question Further information is requested label Aug 17, 2021
@XoBoR XoBoR changed the title How to get the correct machine dimensions for corner bed leveling How to make corner Bed leveling use the Correct Dimensions of my Printer? Aug 17, 2021
@radek8
Copy link
Contributor

radek8 commented Aug 17, 2021

I can confirm the reported problem.
FW TFT will use the values size_min: and size_max:
in the config.ini file,
but does not use values obtained from the printer via the M115 command.

@radek8
Copy link
Contributor

radek8 commented Aug 17, 2021

The problem could be that Marlin reports parameters as lowercase x: y: z: , but TFT expects uppercase X: Y: Z: .

image

@radek8
Copy link
Contributor

radek8 commented Aug 18, 2021

It won't be a problem to fix it.
However, another problem occurs if you have the origin of the x and y axes defined as a negative value. Just like I have on my printer.
In the config.ini file I had a defined desktop as min 0, max 230, and everything worked fine.
if my printer detects the starting point as a negative number, I have a problem with the corner alignment feature.

Perhaps the solution would be to only detect the maximum value, but replace the minimum value if it is less than 0 with zero.

@radek8
Copy link
Contributor

radek8 commented Aug 18, 2021

Unfortunately, if I rewrite large XYZ tags to small xyz, the bed size will not be detected correctly.

  // parse and store build volume size
  else if (ack_seen("work:"))
  {
    if (ack_seen("min:"))
    {
      if (ack_seen("x:")) infoSettings.machine_size_min[X_AXIS] = ack_value();
      if (ack_seen("y:")) infoSettings.machine_size_min[Y_AXIS] = ack_value();
      if (ack_seen("z:")) infoSettings.machine_size_min[Z_AXIS] = ack_value();
    }
    if (ack_seen("max:"))
    {
      if (ack_seen("x:")) infoSettings.machine_size_max[X_AXIS] = ack_value();
      if (ack_seen("y:")) infoSettings.machine_size_max[Y_AXIS] = ack_value();
      if (ack_seen("z:")) infoSettings.machine_size_max[Z_AXIS] = ack_value();
    }
  }

It looks like the result is a return value of 0, because the string sent by Marlin is without spaces.
If it remains as it is, auto-detection will not work.
@guruathwal can you look at that?

@guruathwal
Copy link
Contributor

@radek8 Thanks for looking into it. I will check and try to solve it as soon as possible.

@Dolfino
Copy link

Dolfino commented Oct 15, 2021

Hello everyone involved🖐️
I would like to know if there are any updates on this issue.

@radek8
Copy link
Contributor

radek8 commented Oct 15, 2021

The patch has been created and merged.
In the FW display #2133
and also in in marlin MarlinFirmware/Marlin#22598
So you need to update TFT, but also Marlin.

Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked and limited conversation to collaborators Mar 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants